Adds webhook format check for Slack #814

Noir01 · 2023-11-10T05:37:57Z

Description

Adds webhook format check for Slack

Issues Resolved

fixes #787

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

zhichao-aws

We used mock data to perform integration test. And the mock data may can not pass the new validation. Please also fix the tests in this repo and dashboards-notifications.

Noir01 · 2023-11-10T06:35:50Z

We used mock data to perform integration test. And the mock data may can not pass the new validation. Please also fix the tests in this repo and dashboards-notifications.

I've (hopefully) fixed the integtests in this repo.
I'll go through dashboard-notifications tests and open a PR there soon

Noir01 · 2023-11-10T06:37:03Z

Also, I just noticed the 'Unverified' tags on my commits. I was messing around with the automatic signing off feature and I think I messed up some settings which is leading to all my commits appearing as unverified

Hailong-am · 2023-11-13T01:23:18Z

Also, I just noticed the 'Unverified' tags on my commits. I was messing around with the automatic signing off feature and I think I messed up some settings which is leading to all my commits appearing as unverified

@Noir01 please follow the guide in https://github.com/opensearch-project/notifications/pull/814/checks?check_run_id=18584633999 to fix DCO and there has a unit test failure, can you fix it as well.

Noir01 · 2023-11-13T03:52:59Z

Also, I just noticed the 'Unverified' tags on my commits. I was messing around with the automatic signing off feature and I think I messed up some settings which is leading to all my commits appearing as unverified

@Noir01 please follow the guide in https://github.com/opensearch-project/notifications/pull/814/checks?check_run_id=18584633999 to fix DCO and there has a unit test failure, can you fix it as well.

Can I close this PR and re-open another with the correct signing-off email?

Hailong-am · 2023-11-13T05:53:28Z

Can I close this PR and re-open another with the correct signing-off email?

You don't have to. Follow the guide mentioned in link https://github.com/opensearch-project/notifications/pull/814/checks?check_run_id=18584633999

In your local branch, run: git rebase HEAD~8 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin patch-2

codecov · 2023-11-15T06:47:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.89%. Comparing base (62b7b4f) to head (aa3b636).
Report is 23 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #814      +/-   ##
============================================
+ Coverage     66.85%   66.89%   +0.03%     
- Complexity      263      265       +2     
============================================
  Files            39       39              
  Lines          1738     1740       +2     
  Branches        165      165              
============================================
+ Hits           1162     1164       +2     
  Misses          453      453              
  Partials        123      123

Flag	Coverage Δ
opensearch-notifications	`66.89% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Noir01 · 2023-11-15T06:47:43Z

I was trying to update this branch, and rebased it, but it got rid of the Verified tag. How can I fix this? Also, how do I deal with the failed codecov tests?

Hailong-am · 2023-11-15T07:15:50Z

I was trying to update this branch, and rebased it, but it got rid of the Verified tag. How can I fix this? Also, how do I deal with the failed codecov tests?

The DCO failed with reason

Summary
Commit sha: 7e6b4cd, Author: Aniruddh, Committer: Aniruddh; Can not find "Aniruddh [email protected]", in ["Aniruddh Srivastava [email protected]", "Aniruddh Srivastava [email protected]"].
Commit sha: 0791276, Author: Aniruddh Srivastava, Committer: Aniruddh; Expected "Aniruddh Srivastava [email protected]", but got "Aniruddh Srivastava [email protected]".

can you check the email settings of your account https://github.com/settings/emails make sure Keep my email addresses private is not checked.
make sure you local git config user email is [email protected] with command git config user.email

Noir01 · 2023-11-15T08:00:55Z

I was trying to update this branch, and rebased it, but it got rid of the Verified tag. How can I fix this? Also, how do I deal with the failed codecov tests?

The DCO failed with reason

Summary
Commit sha: 7e6b4cd, Author: Aniruddh, Committer: Aniruddh; Can not find "Aniruddh [email protected]", in ["Aniruddh Srivastava [email protected]", "Aniruddh Srivastava [email protected]"].
Commit sha: 0791276, Author: Aniruddh Srivastava, Committer: Aniruddh; Expected "Aniruddh Srivastava [email protected]", but got "Aniruddh Srivastava [email protected]".

can you check the email settings of your account https://github.com/settings/emails make sure Keep my email addresses private is not checked.

make sure you local git config user email is [email protected] with command git config user.email

I just did both of those steps

Hailong-am · 2023-11-16T02:17:11Z

I just did both of those steps

@Noir01 after this, please follow the steps in https://github.com/opensearch-project/notifications/pull/814/checks?check_run_id=18694631981 to fix DCO

zhichao-aws

Good work, but I think we should add more tests cases. Can we add unit test cases to test more success cases and fail cases for url validation? And the integ test case for exception message?

* Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <[email protected]> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <[email protected]> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <[email protected]> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <[email protected]> * fix build in core Signed-off-by: zhichao-aws <[email protected]> * fix core-spi build Signed-off-by: zhichao-aws <[email protected]> * fix notifications main code Signed-off-by: zhichao-aws <[email protected]> * fix mappings, add IT Signed-off-by: zhichao-aws <[email protected]> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <[email protected]> * put load mapping to initialize step Signed-off-by: zhichao-aws <[email protected]> * add schema_version field Signed-off-by: zhichao-aws <[email protected]> * add integ test Signed-off-by: zhichao-aws <[email protected]> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <[email protected]> * add bwc Signed-off-by: zhichao-aws <[email protected]> * modify bwc Signed-off-by: zhichao-aws <[email protected]> * modify bwc Signed-off-by: zhichao-aws <[email protected]> * resolve comments Signed-off-by: zhichao-aws <[email protected]> * add license header Signed-off-by: zhichao-aws <[email protected]> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> Signed-off-by: Aniruddh <[email protected]>

* add validation failure message for Microsoft Teams Signed-off-by: zhichao-aws <[email protected]> * modify integtest Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]>

Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]>

Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Aniruddh <[email protected]>

* Add 2.10.0 release notes Signed-off-by: Hailong Cui <[email protected]> * update release notes Signed-off-by: Hailong Cui <[email protected]> * Update opensearch-notifications.release-notes-2.10.0.0.md Signed-off-by: Hailong Cui <[email protected]> * fix wrong PR number Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]>

Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]>

Signed-off-by: yuye-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]>

…x warning (opensearch-project#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]>

zhichao-aws · 2023-11-16T06:07:50Z

Good work, but I think we should add more tests cases. Can we add unit test cases to test more success cases and fail cases for url validation? And the integ test case for exception message?

I'm not very experienced in this, so could you explain a bit more?

Please refer to these test cases:

notifications/notifications/notifications/src/test/kotlin/org/opensearch/notifications/index/ConfigIndexingActionsTests.kt

Line 17 in 62b7b4f

fun `test validate microsoft teams`() {

;

notifications/notifications/notifications/src/test/kotlin/org/opensearch/integtest/config/MicrosoftTeamsNotificationConfigCrudIT.kt

Line 132 in 62b7b4f

fun `test create config with wrong Microsoft Teams url and get error text`() {

Got it. Do you only want those two copied for slack?

You know we're adding tests to make sure the code behavior are as expected. And here we want to make sure the url check reject wrong url, and return correct message to help users fix it. You can write test cases just like this example, but I think you should modify these mock urls to adapt to you regex expression

Noir01 · 2023-11-16T06:15:13Z

Good work, but I think we should add more tests cases. Can we add unit test cases to test more success cases and fail cases for url validation? And the integ test case for exception message?

I'm not very experienced in this, so could you explain a bit more?

Please refer to these test cases:

notifications/notifications/notifications/src/test/kotlin/org/opensearch/notifications/index/ConfigIndexingActionsTests.kt

Line 17 in 62b7b4f

fun `test validate microsoft teams`() {

;

notifications/notifications/notifications/src/test/kotlin/org/opensearch/integtest/config/MicrosoftTeamsNotificationConfigCrudIT.kt

Line 132 in 62b7b4f

fun `test create config with wrong Microsoft Teams url and get error text`() {

Got it. Do you only want those two copied for slack?

You know we're adding tests to make sure the code behavior are as expected. And here we want to make sure the url check reject wrong url, and return correct message to help users fix it. You can write test cases just like this example, but I think you should modify these mock urls to adapt to you regex expression

Oh yeah, of course.

Signed-off-by: Aniruddh <[email protected]>

Noir01 · 2023-11-16T08:06:19Z

Good work, but I think we should add more tests cases. Can we add unit test cases to test more success cases and fail cases for url validation? And the integ test case for exception message?

Done.

Hailong-am · 2023-11-17T03:38:26Z

The validation happens when create new slack channel or update existing slack channel. To be compatible with existing data, we may want to add a condition for update case, only if webhook url has changed, we do the validation. we can have this in follow up PR and remove the backport 2.x label for now.

zhichao-aws

lgtm

Noir01 · 2023-12-01T02:38:33Z

The validation happens when create new slack channel or update existing slack channel. To be compatible with existing data, we may want to add a condition for update case, only if webhook url has changed, we do the validation. we can have this in follow up PR and remove the backport 2.x label for now.

@Hailong-am Shall I open a new issue for this?

Hailong-am · 2023-12-01T02:40:28Z

The validation happens when create new slack channel or update existing slack channel. To be compatible with existing data, we may want to add a condition for update case, only if webhook url has changed, we do the validation. we can have this in follow up PR and remove the backport 2.x label for now.

@Hailong-am Shall I open a new issue for this?

sure, thanks

zhichao-aws · 2023-12-01T03:11:16Z

The validation happens when create new slack channel or update existing slack channel. To be compatible with existing data, we may want to add a condition for update case, only if webhook url has changed, we do the validation. we can have this in follow up PR and remove the backport 2.x label for now.

@Hailong-am Shall I open a new issue for this?

sure, thanks

We already have these issues now #818 #819 .

* Microsoft teams (#676) * Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <[email protected]> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <[email protected]> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <[email protected]> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <[email protected]> * fix build in core Signed-off-by: zhichao-aws <[email protected]> * fix core-spi build Signed-off-by: zhichao-aws <[email protected]> * fix notifications main code Signed-off-by: zhichao-aws <[email protected]> * fix mappings, add IT Signed-off-by: zhichao-aws <[email protected]> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <[email protected]> * put load mapping to initialize step Signed-off-by: zhichao-aws <[email protected]> * add schema_version field Signed-off-by: zhichao-aws <[email protected]> * add integ test Signed-off-by: zhichao-aws <[email protected]> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <[email protected]> * add bwc Signed-off-by: zhichao-aws <[email protected]> * modify bwc Signed-off-by: zhichao-aws <[email protected]> * modify bwc Signed-off-by: zhichao-aws <[email protected]> * resolve comments Signed-off-by: zhichao-aws <[email protected]> * add license header Signed-off-by: zhichao-aws <[email protected]> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams Signed-off-by: zhichao-aws <[email protected]> * modify integtest Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> * onboard system and hidden index (#742) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Updates demo certs used in integ tests (#756) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes Signed-off-by: Hailong Cui <[email protected]> * update release notes Signed-off-by: Hailong Cui <[email protected]> * Update opensearch-notifications.release-notes-2.10.0.0.md Signed-off-by: Hailong Cui <[email protected]> * fix wrong PR number Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * bump bwc version to 2.11 (#763) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Impove security plugin enabling check (#792) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow Signed-off-by: Hailong Cui <[email protected]> * revert app id Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <[email protected]> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Add assertion for retrieval of notification Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to suggested version Signed-off-by: rdani <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. Signed-off-by: Noir <[email protected]> * Undid 80fc198 Removed slf4j-jdk14.jar from classpath Signed-off-by: Aniruddh <[email protected]> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath Signed-off-by: Aniruddh <[email protected]> --------- Signed-off-by: Noir <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Added Slack webhook URL validation regex Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace path of mock Slack URL with `sample_slack_url` Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Remove slackId from domainIds Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add tests for wrong Slack URLs Signed-off-by: Aniruddh <[email protected]> * Add validation tests for Slack URL Signed-off-by: Aniruddh <[email protected]> * Format Signed-off-by: Aniruddh <[email protected]> * GovSlack apps can use the slack-gov.com domain Signed-off-by: Aniruddh <[email protected]> * Add validation for gov-slack.com domain Signed-off-by: Aniruddh <[email protected]> --------- Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: yuye-aws <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Noir <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: Rachana Dani <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Peter Zhu <[email protected]> (cherry picked from commit 87109a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Microsoft teams (#676) * Added feature support for microsoft teams webhoo * Added feature support for microsoft teams webhook ,removed valid webhooks * Added feature support for Microsoft teams webhook * Refactored feature support for ms teams and added unit and integTest * fix build in core * fix core-spi build * fix notifications main code * fix mappings, add IT * add auto upgrade mapping logic * put load mapping to initialize step * add schema_version field * add integ test * adjust with auto upgrade mapping logic * add bwc * modify bwc * modify bwc * resolve comments * add license header * fix microsoft teams sample url in IT to adapt url validation --------- * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams * modify integtest --------- * onboard system and hidden index (#742) * Updates demo certs used in integ tests (#756) * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes * update release notes * Update opensearch-notifications.release-notes-2.10.0.0.md * fix wrong PR number --------- * bump bwc version to 2.11 (#763) * Add 2.11 release notes (#774) * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning * Fix bwc test failure of throwing direct access to system index when getting mapping --------- * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` * bump bwc version to 2.12 (#793) * Update dependency org.json:json to v20231013 (#795) * Impove security plugin enabling check (#792) * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow * revert app id --------- * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning * Fix bwc test failure of throwing direct access to system index when getting mapping --------- * Replace the TestMailServer to GreenMail server * bump bwc version to 2.12 (#793) * Update dependency org.json:json to v20231013 (#795) * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` * Add assertion for retrieval of notification * Update to stable version * Update to stable version * Update to suggested version --------- * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions * Add more --------- * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. * Undid 80fc198 Removed slf4j-jdk14.jar from classpath * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath --------- * Added Slack webhook URL validation regex * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replace path of mock Slack URL with `sample_slack_url` * Remove slackId from domainIds * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Add tests for wrong Slack URLs * Add validation tests for Slack URL * Format * GovSlack apps can use the slack-gov.com domain * Add validation for gov-slack.com domain --------- (cherry picked from commit 87109a0) Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: yuye-aws <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Noir <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: Rachana Dani <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Peter Zhu <[email protected]>

zhichao-aws reviewed Nov 10, 2023

View reviewed changes

Noir01 marked this pull request as ready for review November 11, 2023 08:30

Noir01 requested review from xluo-aws, gaobinlong, Hailong-am, SuZhou-Joe, yuye-aws and zhongnansu as code owners November 11, 2023 08:30

Noir01 mentioned this pull request Nov 11, 2023

Replaced wrongly formatted mock Slack URLs with properly formatted mock Slack URLs opensearch-project/dashboards-notifications#139

Merged

1 task

Noir01 force-pushed the patch-2 branch 2 times, most recently from b099c60 to 1867a8a Compare November 15, 2023 06:46

zhichao-aws reviewed Nov 16, 2023

View reviewed changes

zhichao-aws and others added 8 commits November 15, 2023 23:11

onboard system and hidden index (opensearch-project#742)

dc36ba6

Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]>

Updates demo certs used in integ tests (opensearch-project#756)

344a172

Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Aniruddh <[email protected]>

bump bwc version to 2.11 (opensearch-project#763)

7dcca6e

Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]>

Add 2.11 release notes (opensearch-project#774)

93aa732

Signed-off-by: yuye-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]>

Noir01 added 6 commits November 16, 2023 01:23

Add tests for wrong Slack URLs

fe1189d

Signed-off-by: Aniruddh <[email protected]>

Add validation tests for Slack URL

8c17f39

Signed-off-by: Aniruddh <[email protected]>

Format

45823a6

Signed-off-by: Aniruddh <[email protected]>

GovSlack apps can use the slack-gov.com domain

84c17ed

Signed-off-by: Aniruddh <[email protected]>

Merge remote-tracking branch 'origin/patch-2' into patch-2

875048f

Add validation for gov-slack.com domain

aa3b636

Signed-off-by: Aniruddh <[email protected]>

Hailong-am added backport 2.x and removed backport 2.x labels Nov 16, 2023

Hailong-am approved these changes Nov 17, 2023

View reviewed changes

Noir01 requested a review from zhichao-aws November 18, 2023 08:41

zhichao-aws approved these changes Nov 20, 2023

View reviewed changes

zhichao-aws added backport 2.x and removed backport 2.x labels Nov 20, 2023

zhichao-aws merged commit 87109a0 into opensearch-project:main Nov 20, 2023
18 checks passed

Noir01 deleted the patch-2 branch November 20, 2023 04:11

Hailong-am added the OSCI label Nov 22, 2023

Noir01 mentioned this pull request Nov 23, 2023

Adds webhook format check for Chime #816

Merged

1 task

AWSHurneyt mentioned this pull request Nov 29, 2023

[FEATURE] Make "text" message format workaround backwards compatible #819

Open

bowenlan-amzn mentioned this pull request Jan 10, 2024

Fix the notification_setting test by giving a obedient slack url opensearch-project/index-management-dashboards-plugin#961

Merged

1 task

amsiglan added the backport 2.10 label Aug 23, 2024

opensearch-trigger-bot bot mentioned this pull request Aug 23, 2024

[Backport 2.10] Adds webhook format check for Slack #944

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds webhook format check for Slack #814

Adds webhook format check for Slack #814

Noir01 commented Nov 10, 2023 •

edited

Loading

zhichao-aws left a comment •

edited

Loading

Noir01 commented Nov 10, 2023

Noir01 commented Nov 10, 2023

Hailong-am commented Nov 13, 2023

Noir01 commented Nov 13, 2023

Hailong-am commented Nov 13, 2023

codecov bot commented Nov 15, 2023 •

edited

Loading

Noir01 commented Nov 15, 2023 •

edited

Loading

Hailong-am commented Nov 15, 2023

Noir01 commented Nov 15, 2023

Hailong-am commented Nov 16, 2023

zhichao-aws left a comment

zhichao-aws commented Nov 16, 2023

Noir01 commented Nov 16, 2023

Noir01 commented Nov 16, 2023

Hailong-am commented Nov 17, 2023

zhichao-aws left a comment

Noir01 commented Dec 1, 2023

Hailong-am commented Dec 1, 2023

zhichao-aws commented Dec 1, 2023

Adds webhook format check for Slack #814

Adds webhook format check for Slack #814

Conversation

Noir01 commented Nov 10, 2023 • edited Loading

Description

Issues Resolved

Check List

zhichao-aws left a comment • edited Loading

Choose a reason for hiding this comment

Noir01 commented Nov 10, 2023

Noir01 commented Nov 10, 2023

Hailong-am commented Nov 13, 2023

Noir01 commented Nov 13, 2023

Hailong-am commented Nov 13, 2023

codecov bot commented Nov 15, 2023 • edited Loading

Codecov Report

Noir01 commented Nov 15, 2023 • edited Loading

Hailong-am commented Nov 15, 2023

Noir01 commented Nov 15, 2023

Hailong-am commented Nov 16, 2023

zhichao-aws left a comment

Choose a reason for hiding this comment

zhichao-aws commented Nov 16, 2023

Noir01 commented Nov 16, 2023

Noir01 commented Nov 16, 2023

Hailong-am commented Nov 17, 2023

zhichao-aws left a comment

Choose a reason for hiding this comment

Noir01 commented Dec 1, 2023

Hailong-am commented Dec 1, 2023

zhichao-aws commented Dec 1, 2023

Noir01 commented Nov 10, 2023 •

edited

Loading

zhichao-aws left a comment •

edited

Loading

codecov bot commented Nov 15, 2023 •

edited

Loading

Noir01 commented Nov 15, 2023 •

edited

Loading